-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from mono/linker #55813
Conversation
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21365.1
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21366.2
@tlakollo possible RUC regression or libraries changes are needed |
This is basically caused by dotnet/linker#2148. We could workaround it by adding suppressions on the affected types. But the real fix is waiting on dotnet/linker#2136 - which will introduce a new warning code and ability to suppress it on-method - that will require libraries changes (suppressions). |
In case we want to get dependency flow unblocked, these runtime changes should work: sbomer@3f9ebc5. But we'll need to update them again as soon as that issue is fixed, so I'd rather wait for the real fix. |
How far out is the "real fix"? If it is more than a day or two, I'd prefer we unblock the dependency flow. |
Suppress type hierarchy warnings for DynamicallyAccessedMembers attribute on types that have members with RequiresUnreferencedCode (or derived types with such members).
Hopefully just a day or two, but I pushed my changes so we don't have to wait - PTAL. |
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Show resolved
Hide resolved
Microsoft.NET.ILLink.Tasks From Version 6.0.100-preview.6.21362.3 -> To Version 6.0.100-preview.6.21369.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/backport to release/6.0-preview7 |
Started backporting to release/6.0-preview7: https://github.com/dotnet/runtime/actions/runs/1053678159 |
This pull request updates the following dependencies
From https://github.com/mono/linker